【已评审】NtpService资源Actions操作错误引擎描述修改

Interface SIG Interface评审
1

关联issue

支持Redfish资源NtpService下可以导入NTP组密钥-rackmount-GitCode

背景

测试比较V2和V3的运行结果，针对不同的描述提出问题，问题如下：

  1. UploadNTPSecureGroupKeysuccessfully导入成功的"Resolution": "None.“应该是"Resolution”: “None”
  2. 错误引擎NTPGroupKeyNotSupported的Message描述错误
  3. 错误引擎UploadNTPSecureGroupKeyFailed的Resolution描述不合理

评审点

评审点1：UploadNTPSecureGroupKeysuccessfully

“Resolution”: “None.”
修改为
“Resolution”: “None”

示例：

"UploadNTPSecureGroupKeysuccessfully": {
            "Description": "Indicates that an NTP group key is uploaded successfully.",
            "Message": "The NTP group key is uploaded successfully.",
            "Severity": "OK",
            "NumberOfArgs": 0,
            "Resolution": "None",
            "HttpStatusCode": 200,
            "IpmiCompletionCode": "0x00",
            "SnmpStatusCode": 0
        }

评审点2：NTPGroupKeyNotSupported

“Message”: “Failed to upload the NTP group key because it is not support.”
修改为
“Message”: “Failed to upload the NTP group key because it is not supported.”

示例：

"NTPGroupKeyNotSupported": {
            "Description": "Indicates that an error occuerd during the NTP group key upload process.",
            "Message": "Failed to upload the NTP group key because it is not supported.",
            "Severity": "Warning",
            "NumberOfArgs": 0,
            "Resolution": "Make sure that the group key is supported by the NTP.",
            "HttpStatusCode": 400,
            "IpmiCompletionCode": "0xFF",
            "SnmpStatusCode": 3
        }

评审点3：UploadNTPSecureGroupKeyFailed

“Resolution”: “Make sure that the content or URI of the NTP group key in the request body is valid.”
修改为
“Resolution”: “Make sure that the content or URI of the NTP group key specified in the request body is valid.”

"UploadNTPSecureGroupKeyFailed": {
            "Description": "Indicates that an error occuerd during the NTP group key upload process.",
            "Message": "Failed to upload the NTP group key.",
            "Severity": "Warning",
            "NumberOfArgs": 0,
            "Resolution": "Make sure that the content or URI of the NTP group key specified in the request body is valid.",
            "HttpStatusCode": 400,
            "IpmiCompletionCode": "0xFF",
            "SnmpStatusCode": 3
        }

评审结论

通过，具体结论如下：

  • 评审点1：不修改，参考最新的redfish官方message定义，Resolution 为 “None.” 时保持句末的标点符号(.)
  • 评审点2：同意修改，Message 中的 support 修改为 supported
  • 评审点3：同意修改，Resolution 中增加 specified
2

问题 #1：当前评审的标题和评审点没有关系，优化一下评审帖的标题
问题 #2：评审议题的背景不清晰，需要优化描述